Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate QRAO #473

Closed
4 tasks
t-imamichi opened this issue Feb 8, 2023 · 2 comments · Fixed by #487
Closed
4 tasks

Integrate QRAO #473

t-imamichi opened this issue Feb 8, 2023 · 2 comments · Fixed by #487
Labels
Epic type: feature request New feature or request
Milestone

Comments

@t-imamichi
Copy link
Collaborator

t-imamichi commented Feb 8, 2023

What should we add?

Integrate qrao-prototype into Qiskit optimization.

  • discuss whether to_ising returns identity matrix as offset instead of returning offset float value
    • Currently: operator, offset = qp.to_ising()
    • Newly: operator = qp.to_ising()
    • In order not to break API, introducing an option to control output may be useful, e.g., to_ising(offset: bool) to return operator and offset if offset=True, otherwise return only operator.
  • magic rounding needs to be migrated to sampler
  • refactor solve so that QRAO solver can access the problem to be encoded
  • discuss whether allow pytest for unit tests because qrao-prototype uses pytest for unit tests.
@t-imamichi t-imamichi added type: feature request New feature or request Epic labels Feb 8, 2023
@garrison
Copy link
Member

garrison commented Mar 21, 2023

Some comments to follow up on the above points:

@t-imamichi
Copy link
Collaborator Author

This might be related too #325

@woodsp-ibm woodsp-ibm added this to the 0.6.0 milestone Apr 13, 2023
@mergify mergify bot closed this as completed in #487 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants