Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for angular 9 #157

Open
AhmedBenyahia opened this issue Aug 17, 2020 · 7 comments
Open

Add support for angular 9 #157

AhmedBenyahia opened this issue Aug 17, 2020 · 7 comments

Comments

@AhmedBenyahia
Copy link

Starting from angular 9, Renderer has been renamed to Renderer2.
After upgrading to angular 9 I am getting this error:

ERROR in node_modules/@qontu/ngx-inline-editor/inputs/input-base.d.ts:2:10 - error TS2724: Module '"../../../@angular/core/core"' has no exported member 'Renderer'. Did you mean 'Renderer2'?

@ZiedMayel
Copy link

ZiedMayel commented Aug 17, 2020 via email

@AhmedBenyahia
Copy link
Author

It work as a workaround but it need a proper fix.
It's not a good habit to modify the files in node_module manually

@ZiedMayel
Copy link

ZiedMayel commented Aug 17, 2020 via email

@dogetomoon2021
Copy link

dogetomoon2021 commented Feb 7, 2021

@ZiedMayel Can you please elaborate on the steps to follow?

@ZiedMayel
Copy link

@dogetomoon2021

@ZiedMayel Can you please elaborate on the steps to follow?

What do you need exactly? Can you please tell me what do you mean with "elaborate on the steps"?

@dogetomoon2021
Copy link

@ZiedMayel I want to use this lib. with angular 10 or are you aware of any alternative to this lib?

@AhmedBenyahia
Copy link
Author

I suggest u create your own lib. I have created a simple component to replace the old one but it's not in a package, you will need to include it manually in the project: https://github.com/SlaySayto/s-inline-editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants