Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r1ch support #105

Open
gazwald opened this issue Aug 20, 2022 · 4 comments
Open

r1ch support #105

gazwald opened this issue Aug 20, 2022 · 4 comments

Comments

@gazwald
Copy link
Member

gazwald commented Aug 20, 2022

Test and confirm protocol 37 works as expected, or create a separate protocol definition for it.

https://github.com/tastyspleen/r1q2-archive

@darkshade9
Copy link

I would also suggest testing against the latest skullernet Q2Pro and the new protocol 38 being introduced in AQtion if it makes sense

https://github.com/skullernet/q2pro
https://github.com/actionquake/q2pro/tree/aqtion

@gazwald
Copy link
Member Author

gazwald commented Sep 6, 2022

Did some limited testing of Q2Pro here: #104

Do the changes to the protocol in AQtion modify the information sent to the master? I did some preliminary testing and heartbeats/pings seemed to work as expected.

@darkshade9
Copy link

The protocol changes should not have affected how the information gets sent, but we did reduce the amount of data being sent (consolidated game modes into a single field for example, rather than a unique integer field for each type)

@gazwald
Copy link
Member Author

gazwald commented Sep 11, 2022

I toyed with the idea of validating all the key/value pairs that get sent in a heartbeat against the protocol but decided against it. As at the time it felt like a step that adds additional complexity while potentially locking out edge cases, and I'm going for broad compatibility at the moment. Current the master just grabs everything and stores it in DynamoDB as a JSON blob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants