Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support experimental Netty adaptive allocator #40934

Open
franz1981 opened this issue Jun 2, 2024 · 7 comments
Open

Support experimental Netty adaptive allocator #40934

franz1981 opened this issue Jun 2, 2024 · 7 comments
Labels
area/netty area/vertx kind/enhancement New feature or request triage/upstream Used for issues which are caused by issues in upstream projects/dependency

Comments

@franz1981
Copy link
Contributor

franz1981 commented Jun 2, 2024

Description

The new Netty release i.e. https://netty.io/news/2024/05/22/4-1-110-Final.html
allow using the new Netty allocator via -Dio.netty.allocator.type=adaptive which:

  • provide lower memory footprint
  • doesn't uses thread locals (more virtual thread friendly)
  • is faster than the default one (thanks to few changes recently implemented by me)

Implementation ideas

No response

@franz1981 franz1981 added the kind/enhancement New feature or request label Jun 2, 2024
Copy link

quarkus-bot bot commented Jun 2, 2024

/cc @cescoffier (netty), @jponge (netty)

@cescoffier
Copy link
Member

Thanks for opening this. I wonder if this should become the default or not?

As a first step we can add an option to switch to this strategy.

@geoand
Copy link
Contributor

geoand commented Jun 4, 2024

Yeah, let's at least make it trivial for users to opt into this

@cescoffier
Copy link
Member

Working on the bump to Netty 4.1.111. So, we would be able to move this forward.

@franz1981
Copy link
Contributor Author

eclipse-vertx/vert.x#5168

This is highly related to this issue and #41880 given that the reason why vertx got a perf hit allocating byte[] with SSL is coming from eclipse-vertx/vert.x#5168 (comment)

@franz1981
Copy link
Contributor Author

@cescoffier
Copy link
Member

Waiting for upstream release.

@cescoffier cescoffier added area/vertx triage/upstream Used for issues which are caused by issues in upstream projects/dependency labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/netty area/vertx kind/enhancement New feature or request triage/upstream Used for issues which are caused by issues in upstream projects/dependency
Projects
None yet
Development

No branches or pull requests

3 participants