Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific documentation for quarkus.native.add-all-charsets #41876

Closed
fugerit79 opened this issue Jul 13, 2024 · 2 comments
Closed

Specific documentation for quarkus.native.add-all-charsets #41876

fugerit79 opened this issue Jul 13, 2024 · 2 comments
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/native-image

Comments

@fugerit79
Copy link
Contributor

Description

Parameter quarkus.native.add-all-charsets actually fixed connection to oracle database for our project

First of all thanks for all your great work with quarkus, it is the main platform we are using to build new microservice in our project.

Proposed documentation for quarkus.native.add-all-charsets

We just propose to change the documentation for quarkus.native.add-all-charsets parameter from :

If all character sets should be added to the native image. This increases image size

To something like :

If all character sets should be added to the native image (Different from GraalVM option : -H:+AddAllCharsets; this flag enables quarkus extensions to do some specific work). This increases image size

Some context

In the team where I work we are migrating a quarkus microservice to AOT version.
This microservice needs to connect to Oracle.
Everythin went smooth except this error which gave as more than a headache when connecting to oracle :

Missing character set id 871 is not loaded at image build time
	at oracle.sql.CharacterSet.make(CharacterSet.java:114)

At the benning we thought that the option :

quarkus.native.add-all-charsets was the same as the official GraalVM option -H:+AddAllCharsets.

But in the end we found out only the option quarkus.native.add-all-charsets = true actually made our microservice work with oracle.

We actually found out that quarkus extensions too (for instance the oracle one) was doing extra job :
a618020

Implementation ideas

Change the documentation for quarkus.native.add-all-charsets parameter from :

If all character sets should be added to the native image. This increases image size

To something like :

If all character sets should be added to the native image (Different from GraalVM option : -H:+AddAllCharsets; this flag enables quarkus extensions to do some specific work). This increases image size

@fugerit79 fugerit79 added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jul 13, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 13, 2024

/cc @zakkak (native-image)

@fugerit79
Copy link
Contributor Author

Fixed with pull request :

#41877

barreiro pushed a commit to barreiro/quarkus that referenced this issue Jul 25, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/native-image
Projects
None yet
Development

No branches or pull requests

1 participant