Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide quarkus image build --push parameter #41882

Open
weltonrodrigo opened this issue Jul 14, 2024 · 5 comments
Open

Please provide quarkus image build --push parameter #41882

weltonrodrigo opened this issue Jul 14, 2024 · 5 comments
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/container-image kind/enhancement New feature or request

Comments

@weltonrodrigo
Copy link
Contributor

weltonrodrigo commented Jul 14, 2024

Description

It's cumbersome having to write quarkus image build -Dquarkus.container-image.push=true.

In my understanding the quarkus cli is a helper to simplify interaction with the quarkus maven (and gradle, I suppose) plugins. As such it has created a ergonomic DSL to improve productivity.

I believe the --push would be a nice addition to that, but I see that this argument will have to be present in other commands that have an --image-build argument, like:

quarkus deploy kubernetes --image-build -Dquarkus.container-image.push=true would have to become ``quarkus deploy kubernetes --image-build --image-build-push` and so on.

I also understand that having -D arguments some kind of central registry of parameters instead of surfacing parameters to the DSL is a nice compromise, but I also believe that --push is such a common use that it justifies it.

Thanks for this AMAZING software, both quarkus and the quarkus CLI. ♥️

Update: bot, mark this as quarkus cli, please.

Implementation ideas

No response

@weltonrodrigo weltonrodrigo added the kind/enhancement New feature or request label Jul 14, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 14, 2024

/cc @geoand (kubernetes), @iocanel (kubernetes)

@geoand geoand added area/cli Related to quarkus cli (not maven/gradle/etc.) area/container-image and removed area/kubernetes labels Jul 15, 2024
@geoand
Copy link
Contributor

geoand commented Jul 15, 2024

I think this makes sense!

WDYT @iocanel

@iocanel
Copy link
Contributor

iocanel commented Jul 15, 2024

I think there already something like this.

@geoand
Copy link
Contributor

geoand commented Jul 15, 2024

I see there is quarkus image push

@iocanel
Copy link
Contributor

iocanel commented Jul 29, 2024

Exactly. quarkus image push --also-build should do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/container-image kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants