Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus Update - missing recipe for keycloak config changes #42586

Open
Orbifoldt opened this issue Aug 16, 2024 · 4 comments
Open

Quarkus Update - missing recipe for keycloak config changes #42586

Orbifoldt opened this issue Aug 16, 2024 · 4 comments
Labels
area/keycloak env/windows Impacts Windows machines kind/enhancement New feature or request

Comments

@Orbifoldt
Copy link
Contributor

Describe the bug

In 3.13 the keycloak config was updated for when you are using quarkus-test-oidc-server: https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.13#dev-services-startup-detection-change

This required config change doesn't seem to be present in the OpenRewrite recipe: https://github.com/quarkusio/quarkus-updates/blob/main/recipes/src/main/resources/quarkus-updates/core/3.13.alpha1.yaml Not sure if it was intentionally omitted?

In my case, it's configured it in a application.yaml in my /test/resources folder, but as the first link shows it could also be configured via the %test-profile

Expected behavior

The keycloak config is updated from %test.quarkus.oidc.auth-server-url=${keycloak.url}/realms/quarkus/ to %test.quarkus.oidc.auth-server-url=${keycloak.url:replaced-by-test-resource}/realms/quarkus/, even in separate config file in test resources

Actual behavior

Config is not changed

How to Reproduce?

No response

Output of uname -a or ver

windows 11

Output of java -version

17

Quarkus version or git rev

<3.13 to >=3.13

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@Orbifoldt Orbifoldt added the kind/bug Something isn't working label Aug 16, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 16, 2024

/cc @pedroigor (keycloak), @radcortez (config), @sberyozkin (keycloak)

@sberyozkin
Copy link
Member

CC @gsmet

@gsmet
Copy link
Member

gsmet commented Aug 16, 2024

We are not providing recipes for everything that is in the migration guide.
In this case, maybe we could but I'm short on time atm so not entirely sure I will be able to do it.

@gsmet gsmet added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Aug 16, 2024
@gsmet
Copy link
Member

gsmet commented Aug 19, 2024

I tried something but it's unfortunately not so simple because I hit: openrewrite/rewrite#4428 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/keycloak env/windows Impacts Windows machines kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants