Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revealjs chalkboard bug on safari #10842

Open
cscheid opened this issue Sep 19, 2024 · 5 comments
Open

revealjs chalkboard bug on safari #10842

cscheid opened this issue Sep 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working revealjs Issues with the revealjs format
Milestone

Comments

@cscheid
Copy link
Collaborator

cscheid commented Sep 19, 2024

Repro:

---
title: Chalkboard bug
format:
  revealjs:
    chalkboard: true
---

Open this document on Safari 16.6 (and presumably lower) and you see this:

image

Notably, this is resolved if users upgrade to macOS Sequoia (!?)

@cscheid cscheid added bug Something isn't working revealjs Issues with the revealjs format labels Sep 19, 2024
@cscheid
Copy link
Collaborator Author

cscheid commented Sep 19, 2024

The bug happens because somehow we have a .reveal > .overlay element active on safari, which has the following style:

https://github.com/quarto-dev/quarto-cli/blob/main/src/resources/formats/revealjs/reveal/css/reveal.scss#L1446-L1456

The blur itself comes from upstream:

https://github.com/hakimel/reveal.js/blob/5.1.0/css/reveal.scss#L1446-L1456

@cscheid
Copy link
Collaborator Author

cscheid commented Sep 19, 2024

It's a chalkboard bug: rajgoel/reveal.js-plugins#179

@cscheid
Copy link
Collaborator Author

cscheid commented Sep 19, 2024

I see rajgoel/reveal.js-plugins#180, but it doesn't look like it really fixed the issue on Safari for us, @cderv

@cderv
Copy link
Collaborator

cderv commented Sep 20, 2024

😞 It is a bad upstream bug - you found the right link. I used the patched version already
dcd1724 (#10361) - that is really annoying it does not work for safari (I also can't test it on windows I think... 🤔 )

Did you identify in CSS inspector why the rule is not applying ?

If we can identify we can patch our version and report upstream.

@cderv cderv self-assigned this Sep 20, 2024
@cderv cderv added this to the v1.6 milestone Sep 20, 2024
@cscheid
Copy link
Collaborator Author

cscheid commented Sep 20, 2024

The rule at play is .reveal > .overlay, but if you look at it, that rule clearly has an intentional blur() filter. I suspect what's happening is that something in Safari is going wrong and the div should not be visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working revealjs Issues with the revealjs format
Projects
None yet
Development

No branches or pull requests

2 participants