Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance chore - replace Cliffy #10878

Open
cscheid opened this issue Sep 25, 2024 · 8 comments
Open

maintenance chore - replace Cliffy #10878

cscheid opened this issue Sep 25, 2024 · 8 comments
Assignees
Labels
deno Issues related to deno
Milestone

Comments

@cscheid
Copy link
Collaborator

cscheid commented Sep 25, 2024

Cliffy has been a constant source of toil and churn in our codebase, and I'd like to not have to deal with it anymore.

@cscheid cscheid self-assigned this Sep 25, 2024
@cscheid cscheid added this to the Future milestone Sep 25, 2024
@cscheid cscheid added the deno Issues related to deno label Sep 25, 2024
@winniehell
Copy link
Contributor

@cscheid in #10809 (comment) you commented that this issue will happen in 1.7 but here is no milestone assigned.

do you already have plans what to use instead?

@mcanouil
Copy link
Collaborator

mcanouil commented Oct 23, 2024

Milestones are for internal management and does not represent roadmap or promises on what will be done or not in a release.

Thank you for your interest but please avoid pinging developers especially asking things about status.
As you can see, they do update issues when they think there is something worth mentioning to themselves or users.

@winniehell
Copy link
Contributor

sorry, my intention wasn't to ask about status but to offer help. if no previous research for alternative (outside of this issue) has happened, I would do it myself and post the result here.

@winniehell
Copy link
Contributor

Milestones are for internal management and does not represent roadmap or promises on what will be done or not in a release.

I understand but I interpreted the linked comment that not adding a milestone here was just an oversight. no intention to enforce any deadline, just trying to help fix a potential inconsistency in the internal planning.

@cscheid
Copy link
Collaborator Author

cscheid commented Oct 23, 2024

When we have communications that we're ready to share with the public, we do that in the comments.

@winniehell
Copy link
Contributor

winniehell commented Oct 23, 2024

I would make an attempt to replace Cliffy with https://www.npmjs.com/package/clipanion in the hope that it works with Deno (haven't tested yet).

EDIT: tested, works ✅

I've started the migration: main...winniehell:quarto-cli:cliffy-to-clipanion

@winniehell
Copy link
Contributor

currently I focus on the argument / command parsing which is the biggest chunk of cliffy.

for prompts I intend to use https://www.npmjs.com/package/enquirer

for tables I intend to use https://www.npmjs.com/package/cli-table3

@winniehell
Copy link
Contributor

I finished the first part: #11325

…but overlooked that npm imports are not supported by deno bundle: #4955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno Issues related to deno
Projects
None yet
Development

No branches or pull requests

3 participants