-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Epic: single source of truth for document/project information #8700
Comments
I see there's been some work in this direction, with the addition of the I was looking at the |
For reference, project wide engine setting is tracked at: This is a limitation across engine currently I believe.
For script file, we started discussion at Is this the same topic ? I am just cross-referencing to keep track of related topics so that we can all follow. |
Yes, thanks, should've just linked those again directly. |
@jkrumbiegel Yes, I definitely want to fix this. We're nearing a 1.6 release and won't have time to do this between now and then (we plan to release early November). But I would like to spend some time on this in 1.7. Could we revisit this then? I hope to be able to split the work such that some of it can be tackled by the engine code directly (and so you should be able to implement it in the pure-Julia engine). |
Ok sure, if there's nothing I could do now, let's revisit it in November. But I could also get started now if I had a rough outline how to approach these two issues. Whatever works better for you :) |
I think this one will be harder for you to fix, because it involves the code where we bind engines/"targets" to documents. It is pretty messy and mostly outside of an engine's responsibilities.
I think this could be easier (barring unexpected snags in our codebase). I think this one is entirely a matter of implementing Lines 68 to 71 in 8eac0b5
quarto-cli/src/execute/jupyter/jupyter.ts Lines 148 to 151 in 0097478
While the julia engine has: quarto-cli/src/execute/julia.ts Line 70 in 9f4e188
When an engine claims a file, then it's also responsible for providing the converted markdown for that file. See eg the jupyter engine code: quarto-cli/src/execute/jupyter/jupyter.ts Lines 162 to 165 in 0097478
|
Hm are you saying I should check within claimsFile whether the percent script has a To me it seems like a logic bug that engines can claim file types which happens before an |
I only now see that jupyter.ts claims |
That would be nice. Should I send you an email? |
Yes, please: [email protected] |
A number of bugs in Quarto happen because different parts of the code are responsible for reasoning about a .qmd document. We should have a single source of truth on this, and that should be what drives the output of, for example,
quarto inspect
.This is related (but simpler) to our Execution Planner, and solving this will make it easier to do the planner well.
resources:
field in_quarto.yml
#3766metadata-files
#3663quarto inspect
needs to use the same sources of truth asquarto render
#8563Resolution of CLI parameters into metadata or pandoc args
format configuration
include shortcode resolution
include
shortcodes must be resolved earlier than they are #8779See also:
The text was updated successfully, but these errors were encountered: