Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource configuration for internal database deployments incorrect #798

Open
Maximilian-Pfau-P opened this issue Jul 20, 2023 · 2 comments

Comments

@Maximilian-Pfau-P
Copy link

Hi,
the following deployments only have requests specified, no limits:
registry-clair-postgres
registry-quay-database

This leads to following error in OpenShift:
Pod "..." is invalid: spec.containers[0].resources.requests: Invalid value: "2Gi": must be less than or equal to memory limit

An option would be to only specify limits (instead of only specifiing requests). Then OpenShift automatically add requests with the same value as the specified limits.

Could you please change this?

@dmesser
Copy link
Contributor

dmesser commented Jul 24, 2023

Hm, I just tried it with the 3.8.10 operator on OCP 4.13 and it doesn't raise this issue. The Deployment just has resource request for CPU and RAM, but no limits and that should suffice. Can you post your generated resources including status blocks as well as QuayRegistry setting?

@Maximilian-Pfau-P
Copy link
Author

Your right, sorry for that. The LimitRange automatically assigned a resource limit which was causing the error.

Nevertheless it would be beneficial to have a Resource Limit in place as well. Are there reasons why they are not configured per default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants