Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request(cli): lint directories #1167

Closed
vegerot opened this issue Jan 5, 2024 · 2 comments
Closed

feature request(cli): lint directories #1167

vegerot opened this issue Jan 5, 2024 · 2 comments

Comments

@vegerot
Copy link
Contributor

vegerot commented Jan 5, 2024

Problem:
I want to run quick-lint on a large project (120k files, 6m SLoC).

Approaches tried:

  • quick-lint-js $(fd ...) zsh can't handle that many arguments
  • manually calling exec("/usr/local/bin/quick-lint-js", ...) fails because it exceeds NCARGS
  • writing my own script that batches calls to quick-lint in batch sizes of NCARGS works but is inconvenient to users

Recommendation:
quick-lint's CLI should also accept a directory. quick-lint will recursively find all appropriate files (.js, .ts, etc.) and lint them.

$ quick-lint-js .

Out of scope:
Respect .gitignore files. This is actually a requirement for my use-case because I don't want to lint node_modules/, dist/, and a bunch of hidden caches my build system creates. This is also the default behavior of fd.

@vegerot
Copy link
Contributor Author

vegerot commented Jan 5, 2024

note: #1166 is an alternative solution

@strager
Copy link
Collaborator

strager commented Jan 5, 2024

Duplicate of #221

@strager strager marked this as a duplicate of #221 Jan 5, 2024
@strager strager closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants