Regarding JdbcStore managing two sequences in a single record.

[ydh6226]

Hi,

I'm curious about the JdbcStore logic to store the incoming_seqnum and outgoing_seqnum in the same record of the session table.

quickfixj/quickfixj-core/src/main/java/quickfix/JdbcStore.java

Lines 117 to 118 in 50d0046

	SQL_UPDATE_SESSION = "UPDATE " + sessionTableName + " SET creation_time=?, "
	+ "incoming_seqnum=?, outgoing_seqnum=? " + "WHERE " + idWhereClause;

Since both the incoming and outgoing processes are trying to update the same record, this approach seems to induce a potential race condition and low throughput.

In contrast, FireStore keeps these sequences in separate files.

Is there a specific reason why JdbcStore does not follow a similar approach by keeping the two sequences in separate records?

Are there any advantages to the current logic that I am not aware of?

Or do you think there is no performance difference?

Thanks.

[chrjohn]

The reason for this is probably that no-one ever felt that this needs to be changed.
There probably is a performance impact the way it is now.
Feel free to suggest changes in a PR. :)