Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sources from the API #5634

Open
rdettai opened this issue Jan 15, 2025 · 0 comments
Open

Update sources from the API #5634

rdettai opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@rdettai
Copy link
Contributor

rdettai commented Jan 15, 2025

Is your feature request related to a problem? Please describe.
Updating a source is currently not possible. It would be very valuable because some paramters like the transform or the num_pipelines might need to evolve through time.

Describe the solution you'd like
A REST endpoint

PUT api/v1/indexes/<index id>/sources/<source id>

Like the index update, the body would be a full source config file (json or yaml):

  • it would only be valid to update some specific fields: num_pipelines, transform, params
    • updating params is a footgun for some source types, but it's still valuable (e.g update kafka ssl settings)
  • source_id and source_type cannot be updated.

Describe alternatives you've considered
Recreating a source with the new params is usually not a good idea because you would loose the checkpoints.

Additional context
NA

@rdettai rdettai added the enhancement New feature or request label Jan 15, 2025
@rdettai rdettai self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant