Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some types appear in quinn's public API which are not accessible through quinn directly #2012

Closed
gretchenfrage opened this issue Oct 11, 2024 · 2 comments · Fixed by #2031
Closed

Comments

@gretchenfrage
Copy link
Contributor

One example of this was noted in #1757:

Another example is that StreamId's public API involves Side and Dir, but Side and Dir cannot be referenced without adding quinn_proto in addition to quinn as a dependency.

If this is indeed something we wish to avoid, it would be nice to have some automated tool which could detect such cases.

@djc
Copy link
Member

djc commented Oct 12, 2024

We generally want to fix these. Don't know that automated tools for this exist?

@gretchenfrage
Copy link
Contributor Author

Yes, I wasn't aware of one existing and at a cursory glance I didn't find one. Which seems a bit odd given how useful and not-that-hard this seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants