Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReconstructStatesPLM causes invalid cells in RadTube problem #681

Open
chongchonghe opened this issue Jul 24, 2024 · 0 comments
Open

ReconstructStatesPLM causes invalid cells in RadTube problem #681

chongchonghe opened this issue Jul 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@chongchonghe
Copy link
Contributor

chongchonghe commented Jul 24, 2024

Describe the bug

ReconstructStatesPLM in the RadTube problem produces invalid (ghost) cells in the RadTube problem. Using ReconstructStatesPPM clears this issue.

Note: That it happens in "ghost" cells is a speculation. What I observe is that the 33th cell is a NAN and caused this error, so I speculate 33 = 32 + 1 is the ghost cell. I'm not sure if you do have a ghost cell when running it on a single core on CPU. The domain is resolved with 128 grids in this problem.

To Reproduce
Steps to reproduce the behavior:

  1. In development branch, set radiationReconstructionOrder_ = 2 and reconstructionOrder_ = 2 in the RadTube test, compile it in Debug mode, and run it.
  2. The program immediately fail with "Erroneous arithmetic operation". This error occurred inside HydroSystem<problem_t>::FlattenShocks

Additional context
Add any other context about the problem here.

@chongchonghe chongchonghe added the bug Something isn't working label Jul 24, 2024
@chongchonghe chongchonghe changed the title reconstructionOrder_ = 2 ReconstructStatesPLM causes invalid cells in RadTube problem Jul 24, 2024
@BenWibking BenWibking added floating-point issue with floating-point roundoff error and removed floating-point issue with floating-point roundoff error labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants