Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projection outputs should be 2D plotfiles #685

Closed
BenWibking opened this issue Jul 25, 2024 · 0 comments · Fixed by #791
Closed

projection outputs should be 2D plotfiles #685

BenWibking opened this issue Jul 25, 2024 · 0 comments · Fixed by #791
Assignees
@BenWibking
Labels
enhancement New feature or request user experience

Comments

@BenWibking
Copy link
Collaborator

BenWibking commented Jul 25, 2024 •
edited
Loading

Describe the proposal
We create NxNx1 3D grids when outputting projections (https://quokka-astro.github.io/quokka/insitu_analysis.html#d-projections).

However, it would make a lot more sense to output 2D plotfiles, since the data is actually 2D.

Describe alternatives you've considered
Keep as is.

Additional context
The slice outputs are already 2D plotfiles (https://quokka-astro.github.io/quokka/insitu_analysis.html#d-slices).
@BenWibking BenWibking added the enhancement New feature or request label Jul 25, 2024
@BenWibking BenWibking self-assigned this Jul 25, 2024
@BenWibking BenWibking mentioned this issue Nov 5, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 8, 2024
@BenWibking @pre-commit-ci
Write 2D plotfiles for projections (#791)
e470861 
### Description
Writes projections as 2D plotfiles, rather than as 3D plotfiles with one
cell in the 3rd dimension.

### Related issues
Fixes #685.

### Checklist
_Before this pull request can be reviewed, all of these tasks should be
completed. Denote completed tasks with an `x` inside the square brackets
`[ ]` in the Markdown source below:_
- [x] I have added a description (see above).
- [x] I have added a link to any related issues see (see above).
- [x] I have read the [Contributing
Guide](https://github.com/quokka-astro/quokka/blob/development/CONTRIBUTING.md).
- [ ] I have added tests for any new physics that this PR adds to the
code.
- [x] I have tested this PR on my local computer and all tests pass.
- [x] I have manually triggered the GPU tests with the magic comment
`/azp run`.
- [x] I have requested a reviewer for this PR.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenWibking BenWibking

Labels
enhancement New feature or request user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Write 2D plotfiles for projections quokka-astro/quokka
1 participant
@BenWibking