Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid-aligned nonlinear thin shell instability #717

Open
BenWibking opened this issue Aug 19, 2024 · 3 comments
Open

grid-aligned nonlinear thin shell instability #717

BenWibking opened this issue Aug 19, 2024 · 3 comments
Labels
hydro question Further information is requested

Comments

@BenWibking
Copy link
Collaborator

BenWibking commented Aug 19, 2024

Describe the bug
We seem to be very susceptible to producing thin shells that are aligned with the grid axes when the thin-shell radius is not well resolved ($\Delta x \gg 10^{-2}$ pc).

To Reproduce
Steps to reproduce the behavior:

  1. Run the metal advection problem
  2. Examine the density structure near the midplane
  3. See thin shells in square, grid-like patterns

Additional context
This appears to be a known problem. See, e.g., section 3.6 "Grid-forced instabilities of underresolved dense shells": https://academic.oup.com/mnras/article/507/1/1492/6348113#290180922.

Figure 2 of above:
image

cc @markkrumholz @aditivijayan

@BenWibking BenWibking added bug Something isn't working question Further information is requested and removed bug Something isn't working labels Aug 19, 2024
@BenWibking BenWibking changed the title grid-aligned nonlinear thin shells grid-aligned nonlinear thin shell instability Aug 19, 2024
@dosubot dosubot bot added the bug Something isn't working label Aug 19, 2024
@BenWibking BenWibking removed the bug Something isn't working label Aug 19, 2024
@BenWibking
Copy link
Collaborator Author

@markkrumholz @aditivijayan It might be the case that nothing can be done about this (except to increase the resolution whenever feasible).

Have you noticed this in other simulations?

@markkrumholz
Copy link
Collaborator

@aditivijayan and I did see this, but it was a very short-lived feature that only appeared relatively early in the simulation before the outflow was well-established and when SNe were still going off largely in quite dense gas. Since we drop that portion of the simulation from the analysis in any event (since it's before the flow comes into statistical steady state), we didn't make any effort to fix it.

@BenWibking
Copy link
Collaborator Author

Ok, thanks. I'm not actually worried about this for the global properties of these simulations, I just wanted to keep track of this for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hydro question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants