Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add radhydro problem to nightly regression tests #743

Open
BenWibking opened this issue Sep 17, 2024 · 0 comments
Open

add radhydro problem to nightly regression tests #743

BenWibking opened this issue Sep 17, 2024 · 0 comments
Labels
CI enhancement New feature or request

Comments

@BenWibking
Copy link
Collaborator

Describe the proposal
We currently only test hydro + optically-thin cooling in the regression test suite (https://quokka-astro.github.io/regression-testing-results/).

We should add a radhydro problem to ensure that the output and performance does not change unexpctedly.

Describe alternatives you've considered
Leave regression tests as-is.

Additional context
We have many test problems with exact solutions for radiation, but we don't currently know if there are perturbations smaller than the error thresholds.

We also don't know whether there are performance improvements/regressions over time. The regression test suite automatically tells us this, e.g.: https://quokka-astro.github.io/regression-testing-results/RandomBlast-GPU-timings.html

@BenWibking BenWibking added enhancement New feature or request CI labels Sep 17, 2024
@BenWibking BenWibking changed the title add radhydro problem to regression tests add radhydro problem to nightly regression tests Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant