Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add small fix to HLLD solver from Athena++ #746

Open
BenWibking opened this issue Sep 23, 2024 · 0 comments
Open

add small fix to HLLD solver from Athena++ #746

BenWibking opened this issue Sep 23, 2024 · 0 comments
Assignees
Labels
bug Something isn't working MHD

Comments

@BenWibking
Copy link
Collaborator

Describe the bug
One of the degeneracy checks in the HLLD solver should not be used. See: PrincetonUniversity/athena#620

Additional context
From PrincetonUniversity/athena#620:

It turned out that we should not remove the double-star states even when the normal magnetic field bx is very weak. If this branch is selected when bx is actually non-zero, it may return unphysical flux. In fact, this check is not mentioned in Miyoshi & Kusano 2005 but already existed in the old Athena,

I do not think this has affected many people, as this is problematic only when the magnetic fields are very weak and the flow is not smooth. The probability that this branch is selected is very low in a realistic flow.

@BenWibking BenWibking added bug Something isn't working MHD labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MHD
Projects
None yet
Development

No branches or pull requests

2 participants