Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS #749

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Create CODEOWNERS #749

merged 3 commits into from
Sep 25, 2024

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Sep 24, 2024

Description

Adds a CODEOWNERS file.

Subdirectories and files are listed alongside users and PRs that modify files that match these patterns (either subdirectories or individual files) have to be approved by one of the listed GitHub users in order to be merged. It is necessary to have more than one person listed for any given set of files, since users cannot approve their own pull requests, and in case someone is unavailable or at a conference, etc.

See docs: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#codeowners-and-branch-protection

Related issues

Closes #747.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 24, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 24, 2024
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 24, 2024

@chongchonghe
Copy link
Contributor

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 25, 2024
@BenWibking BenWibking added this pull request to the merge queue Sep 25, 2024
Merged via the queue into development with commit a1632ff Sep 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add CODEOWNERS file
3 participants