Quotient::NAM doesn't retry on errors #727
Assignees
Labels
bug/fix
The library doesn't work as expected
Comments
KitsuneRal
changed the title
KitsuneRal
added a commit
that referenced
this issue
Apr 14, 2024
The commit adds very naive retries to quotest's DownloadRunner, while the proper fix for #727 is in the works.
KitsuneRal
added a commit
that referenced
this issue
Apr 16, 2024
The commit adds very naive retries to quotest's DownloadRunner, while the proper fix for #727 is in the works.
KitsuneRal
added a commit
that referenced
this issue
Apr 16, 2024
The commit adds very naive retries to quotest's DownloadRunner, while the proper fix for #727 is in the works.
KitsuneRal
added a commit
that referenced
this issue
Apr 16, 2024
The commit adds very naive retries to quotest's DownloadRunner, while the proper fix for #727 is in the works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
CI status for libQuotient is downright useless because of one test sporadically failing, most likely due to
429 Too Many Requests"Internal server error" returned toQuotient::NAMthat doesn't know how to handle it (BaseJob-backed requests would retry on it). This failure is not exactly bogus - it basically indicates that requests issued directly toNAM(e.g. those coming from QML directly, rather than via image providers) will sometimes equally fail in real usage.To fix this, code that handles retries has to be moved from
BaseJobandConnectionDatatoNAMinstead.The text was updated successfully, but these errors were encountered: