Questions related to qip

[purva-thakre]

@BoxiLi What's a preferred way to import modules ?

There's no consistent style in all of the qutip-qip modules. In some cases, the absolute path has been specified whereas some use relative imports. Since I am making changes to how Gate class is imported, I can change imports for others as well.

BTW sorry for too many questions ! I though it would be better to start a discussion instead of creating issues for each question.

[BoxiLi]

sorry for too many questions ! I though it would be better to start a discussion instead of creating issues for each question.

No worries, it is good to make thing clear in advance, to prevent unnecessary waste of time. Yeah for style discussion and code design, the discussion panel does seem to be a better place.

Actually, it is something open to discuss. I used to use absolute importation. But that caused some problem when moving from qutip.qip, to qutip_qip because I need to rename every imporation. So, my options are:

• For importation from qutip: we should only use the top namespace qutip, either import qutip or from qutip import mesolve. Things like from qutip.qobj import Qobj should be removed because qutip_qip now is a down stream package and in qutip v5 everything is moved around.
• For importation within qutip_qip: I don't really have a preference. For me, I'm using relative importation in all the newly written code, like from .circuit import QubitCuit. If you prefer others, it is also fine.
• For importation in tests: I think import from import qutip_qip or from qutip_qip import ... is better because we are testing an installed package.

Sorry that the style is a bit mixed. There is a mixture of 7-year-old code and 7-day-old code here :)

[rum1887]

hi, I get the following error when I try to build the doc!

[hodgestar]

To build the docs you need to install the requirements listed in https://github.com/qutip/qutip-doc/blob/master/requirements.txt.

Probably https://qutip-qip.readthedocs.io/en/latest/contribution-docs.html#building-the-documentation should be updated to mention this.

Once you have the docs building, would you mind submitting a pull request to update the docs build documentation linked to above?

[hodgestar]

@rum1887 You posted this to a very old unrelated thread. I'm going to close this discussion so that others don't make the same mistake, but please feel free to open an new one or an issue if you need to.

[rum1887]

Sure!