Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] Stackblitz pkg.pr.new templates #889

Open
maiieul opened this issue Jul 18, 2024 · 0 comments
Open

[✨] Stackblitz pkg.pr.new templates #889

maiieul opened this issue Jul 18, 2024 · 0 comments
Assignees
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it TYPE: enhancement New feature or request

Comments

@maiieul
Copy link
Contributor

maiieul commented Jul 18, 2024

Would be cool to have the pkg.pr.new templates work. This would allow people to play with the components live. But maybe there are better/simpler approaches for us.

It's not easy with nx because stackblitz expects a standalone repository (think something like the output of pnpm create qwik@latest).

maiieul: I made an attempt in #863, but I had to create a standalone repository without nx inside our nx monorepo, and install @qwik-ui/headless in the root package.json, which we're not supposed to do with nx.

We also need to think if we really want to maintain a "sink".

Potential solutions:

  1. install nx inside the standalone repository as well
  2. write a script executed on CI that copies the component files and puts them into a standalone fresh pnpm create qwik@latest project so that it easily works out of the box in stackblitz
@maiieul maiieul added TYPE: enhancement New feature or request COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMMUNITY: PR is welcomed We think it's a good feature to have but would love for the community to help with the PR for it TYPE: enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

2 participants