Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light edits chapter 6 #198

Merged
merged 6 commits into from
Nov 21, 2023
Merged

light edits chapter 6 #198

merged 6 commits into from
Nov 21, 2023

Conversation

tgerke
Copy link
Collaborator

@tgerke tgerke commented Nov 7, 2023

No description provided.

@tgerke
Copy link
Collaborator Author

tgerke commented Nov 7, 2023

There is one odd thing that's happening on my end: park closing time is coming in as seconds and not a date/time format.

> parks_metadata_raw |> select(mkclose)
# A tibble: 2,079 × 1
   mkclose   
   <hms>     
 1 90000 secs
 2 90000 secs
 3 90000 secs

Then, things like hour(park_close) (line 367) don't work. Seems weird though since that chunk produces an appropriate plot in the currently rendered version of the book. Any ideas?

@malcolmbarrett
Copy link
Collaborator

Hmm I see them correctly as time objects, both with parks_metadata_raw and actually data like seven_dwarfs_train_2018 |> select(park_close)

@tgerke
Copy link
Collaborator Author

tgerke commented Nov 7, 2023

what the heck!? Here's MWE in a clean session:

> pak::pkg_install("LucyMcGowan/touringplans")
                                                                     
ℹ No downloads are needed
✔ 1 pkg: kept 1 [774ms]
> touringplans::parks_metadata_raw |> dplyr::select(mkclose)
# A tibble: 2,079 × 1
   mkclose   
   <hms>     
 1 90000 secs
 2 90000 secs
 3 90000 secs
 4 86400 secs
 5 82800 secs
 6 75600 secs
 7 75600 secs
 8 75600 secs
 9 75600 secs
10 82800 secs
# ℹ 2,069 more rows
# ℹ Use `print(n = ...)` to see more rows

@LucyMcGowan any clue what's going on here?

@malcolmbarrett
Copy link
Collaborator

covered that in an issue in touringplans

@malcolmbarrett malcolmbarrett merged commit f011422 into r-causal:main Nov 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants