Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorship of third-party code #45

Open
aitap opened this issue Sep 11, 2024 · 6 comments
Open

Authorship of third-party code #45

aitap opened this issue Sep 11, 2024 · 6 comments
Assignees
Labels
question Further information is requested

Comments

@aitap
Copy link

aitap commented Sep 11, 2024

Every now and then, there is a need to directly include third-party code in an R package without a way to link to an external build of it as recommended by the policy. Here's a recent example: R-package-devel thread, eventual CRAN package with lots of cph, ctb co-authors. After a recent change in ?person, all the "natural person" co-authors are automatically considered cph. Do I understand it correctly that the correct way to include third-party code now is as follows?

  1. Try to find a way not to
  2. Locate all co-authors and copyright holders, possibly reading the version control history if the project doesn't provide an official list of authors
  3. Mark "natural person" co-authors as ctb, organisations as cph, ctb
  4. For multiple cph co-authors, specify the ownership details in the comment argument
@llrs

This comment was marked as off-topic.

@aitap

This comment was marked as resolved.

@llrs

This comment was marked as outdated.

@jasdumas jasdumas self-assigned this Sep 12, 2024
@jasdumas
Copy link
Contributor

Hi @aitap, Thanks for your question. I'm going to be writing up a somewhat relevant recipe issue: Description file: Using Authors@R soon and I'll take some time to think about how this question can be answered and included as a callout note at least for reference.

@jasdumas jasdumas added the question Further information is requested label Sep 12, 2024
@aitap
Copy link
Author

aitap commented Sep 12, 2024

Thank you! I see the policy for organisations is being updated as well.

@Baltmann01
Copy link
Contributor

Small comment from my side as CRAN newbie submission team member:
Your list looks like a great summary. I can only tell you what I look for in packages with third-party code.
And packages following your list would probably pass my review (at least regarding this issue).

@jasdumas jasdumas mentioned this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants