Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formating, sectioning, etc in general edit of docs #191

Open
hturner opened this issue Sep 5, 2024 · 1 comment
Open

Improve formating, sectioning, etc in general edit of docs #191

hturner opened this issue Sep 5, 2024 · 1 comment

Comments

@hturner
Copy link
Member

hturner commented Sep 5, 2024

In recent version we have built up the online docs: https://contributor.r-project.org/r-dev-env/.

The quality could be improved with a general edit. Some particular issues I have noticed:

  1. Inconsistency in list/section style

    Some sections use enumerated lists, e.g. creating codespace, some use 1) style numbering which is not recognised as a markdown list, e.g. Running R, some use this style in subsection headers, e.g. updating source code. It would be good to have more consistency, using proper markdown enumerated lists or unnumbered sections where appropriate. Note that subsections get added to the navigation - not sure what the limit is, but even level 4 headers are added - and these allow you to use anchored links, which can be helpful, e.g. Close R terminal. It would also be good to add permalinks to the section headers, perhaps with a link symbol.

  2. Issues in page/section headers

    Sometimes page headers are (effectively) duplicated, e.g. Start Workspace, other times they need separating out from list/sub-section headers, e.g.
    1. Example Contribution Workflow using the R Dev Container: in the R Contribution Workflow section is really a title for the whole page, not just item 1 of the list.

  3. Incorrect indentation

    We mostly caught this in the initial PR review, but there are still some stray examples, e.g. the > Before edit paragraph in the Editing Source Code section needs to be indented so that it aligns under point 2 in the list.

Having some fresh eyes review and edit the documentation as a whole would be very helpful!

@hturner
Copy link
Member Author

hturner commented Sep 5, 2024

Taking advantage of further features of mkdocs could also come into this general edit, e.g. can we add search to the docs?

ns-rse added a commit to ns-rse/r-dev-env that referenced this issue Oct 11, 2024
As part of r-devel#191 the style of sub-headings for instructions in the `docs/tutorials/` section.

Level 4 markdown headings have been used, where numbering is required these have been included as the number followed by
a period.

Two pages (`multi_r_compilation.md` and `running_r.md`) had paragraphs numbered. These have had short section headers
added and the text follows as paragraphs afterwards.
ns-rse added a commit to ns-rse/r-dev-env that referenced this issue Oct 18, 2024
As part of r-devel#191 the style of sub-headings for instructions in the `docs/tutorials/` section.

+ Level 2 markdown headings have been used, where numbering is required these have been included as the number followed
  by a period.
+ Bullet points have been converted to paragraphs.
+ alt text added to images.
+ titles added to code blocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant