Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading devtools should not cause shiny to be loaded #2523

Closed
wch opened this issue Jul 10, 2023 · 1 comment
Closed

Loading devtools should not cause shiny to be loaded #2523

wch opened this issue Jul 10, 2023 · 1 comment

Comments

@wch
Copy link
Member

wch commented Jul 10, 2023

Currently, loading devtools causes shiny to be loaded, but it shouldn't. This is because devtools imports miniUI, which imports shiny.

Searching the code for miniUI, I see only this (and the corresponding entry in NAMESPACE):

#' @importFrom miniUI miniPage

Searching for miniPage, I see no other uses of it. So I think miniUI can be removed as a dependency, and I think this will make it so shiny will no longer be needed at all by devtools.

@jennybc
Copy link
Member

jennybc commented Jul 10, 2023

Closing in favor of #2524

@jennybc jennybc closed this as completed Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants