From 0ecb11e51eec02bbf8455a2598b813bd8b7a3933 Mon Sep 17 00:00:00 2001 From: Jenny Bryan Date: Tue, 11 Jul 2023 20:47:15 -0700 Subject: [PATCH] Don't import functions from miniUI, profvis, urlchecker Closes #2524 --- NAMESPACE | 3 --- R/devtools-package.R | 10 +++++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/NAMESPACE b/NAMESPACE index 6ad5b66d6..b9b6527f3 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -85,7 +85,6 @@ importFrom(cli,cat_rule) importFrom(ellipsis,check_dots_used) importFrom(lifecycle,deprecated) importFrom(memoise,memoise) -importFrom(miniUI,miniPage) importFrom(pkgbuild,clean_dll) importFrom(pkgbuild,find_rtools) importFrom(pkgbuild,has_devel) @@ -93,7 +92,6 @@ importFrom(pkgbuild,with_debug) importFrom(pkgload,check_dep_version) importFrom(pkgload,parse_deps) importFrom(pkgload,unload) -importFrom(profvis,profvis) importFrom(remotes,dev_package_deps) importFrom(remotes,github_pull) importFrom(remotes,github_release) @@ -112,7 +110,6 @@ importFrom(remotes,update_packages) importFrom(sessioninfo,package_info) importFrom(sessioninfo,session_info) importFrom(stats,update) -importFrom(urlchecker,url_check) importFrom(usethis,ui_code) importFrom(usethis,ui_done) importFrom(usethis,ui_field) diff --git a/R/devtools-package.R b/R/devtools-package.R index 96df5c611..510dbf097 100644 --- a/R/devtools-package.R +++ b/R/devtools-package.R @@ -11,8 +11,12 @@ ## usethis namespace: start #' @importFrom lifecycle deprecated -#' @importFrom miniUI miniPage -#' @importFrom profvis profvis -#' @importFrom urlchecker url_check ## usethis namespace: end NULL + +# https://r-pkgs.org/dependencies-in-practice.html#how-to-not-use-a-package-in-imports +ignore_unused_imports <- function() { + miniUI::miniPage + profvis::profvis + urlchecker::url_check +}