Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url_build() doesn't validate argument #482

Open
JosiahParry opened this issue Jun 27, 2024 · 0 comments · May be fixed by #550
Open

url_build() doesn't validate argument #482

JosiahParry opened this issue Jun 27, 2024 · 0 comments · May be fixed by #550
Labels
feature a feature request or enhancement url 👑

Comments

@JosiahParry
Copy link

JosiahParry commented Jun 27, 2024 •
edited
Loading

It's quite clear I didn't perfectly read the docs! But it would be quite nice if invalid names are found that an error (and better and informative one!) are provided.

httr2::url_build(list(host = host, port = port))
#> "//:3000"

Whereas I expected:

#> "http://127.0.0.1:3000"
@hadley hadley added the feature a feature request or enhancement label Jul 10, 2024
@hadley hadley added the url 👑 label Sep 6, 2024
JosiahParry added a commit to JosiahParry/httr2 that referenced this issue Sep 16, 2024
@JosiahParry
add validation to url_build closes r-lib#482
96e45da
@JosiahParry JosiahParry linked a pull request Sep 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature a feature request or enhancement url 👑
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validation for url_build() JosiahParry/httr2
2 participants
@hadley @JosiahParry