Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing space in download info message #535

Closed
wants to merge 1 commit into from

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Sep 5, 2023

Took a guess, but thought this would add the space missing here.

# now
 Downloaded 1 package (260.26 kB)in 1.5s    
# hopefully with this PR
 Downloaded 1 package (260.26 kB) in 1.5s    

Lmk if that is not the correct place.

Took a guess, but thought this would add the space missing here.

 Downloaded 1 package (260.26 kB)in 1.5s    

Lmk if that is not the correct place.
@olivroy olivroy changed the title Update print.R Add missing space in download info message Sep 5, 2023
@gaborcsardi
Copy link
Member

Seems like it is not the correct place (see the failing tests). Maybe we should add it at the beginning of in 1.5s, but IDK if that's in pak or pkgdepends.

@olivroy
Copy link
Contributor Author

olivroy commented Sep 5, 2023

Indeed, sorry. I just made a quick try. :)

@olivroy olivroy closed this Sep 5, 2023
@olivroy olivroy deleted the patch-1 branch September 5, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants