Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging around local_install() is confusing #665

Open
jennybc opened this issue Jul 22, 2024 · 0 comments
Open

Messaging around local_install() is confusing #665

jennybc opened this issue Jul 22, 2024 · 0 comments

Comments

@jennybc
Copy link
Member

jennybc commented Jul 22, 2024

We've got Ctrl/Cmd + Shift + B in Positron wired up to pak::local_install(upgrade = FALSE) right now, so I'm using it alot and have had ample time to stare at its messaging. I would really like to keep using pak for this or at least make it one of two pre-configured options (see further discussion at posit-dev/positron#2955), because I really like what upgrade = FALSE does (more background in posit-dev/positron#1631 and posit-dev/positron#1732).

> pak::local_install(upgrade = FALSE)
✔ Updated metadata database: 4.28 MB in 4 files.
✔ Updating metadata database ... done
 
→ Will update 1 package.
→ The package (0 B) is cached.
+ usethis 2.2.3.9000 → 2.2.3.9000 👷🏿‍♂️
ℹ No downloads are needed, 1 pkg is cached
✔ Got usethis 2.2.3.9000 (source) (96 B)
ℹ Packaging usethis 2.2.3.9000
✔ Packaged usethis 2.2.3.9000 (4.2s)
ℹ Building usethis 2.2.3.9000
✔ Built usethis 2.2.3.9000 (2.6s)
✔ Installed usethis 2.2.3.9000 (local) (44ms)
✔ 1 pkg + 30 deps: kept 28, upd 1, dld 1 (NA B) [20.6s]

A few aspects of this seem weird to me, given that I'm installing from local source.

ℹ No downloads are needed, 1 pkg is cached

Somehow this makes me feel like pak is going to use some previously-downloaded-and-cached version of usethis, instead of local source. I do understand that is not what's happening, but the message has made me think about it.

✔ 1 pkg + 30 deps: kept 28, upd 1, dld 1 (NA B) [20.6s]

This line also seems a bit misleading. I assume usethis is the "1 pkg" and not considered part of the "30 deps". But then ... is it the 1 package that was ?updated? and ?downloaded? in the "kept 28, upd 1, dld 1" part 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant