Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version_tooltip doesn't seem to work as expected. #2692

Open
olivroy opened this issue Jul 4, 2024 · 2 comments · May be fixed by #2694
Open

version_tooltip doesn't seem to work as expected. #2692

olivroy opened this issue Jul 4, 2024 · 2 comments · May be fixed by #2694

Comments

@olivroy
Copy link
Collaborator

olivroy commented Jul 4, 2024

I found one notable usage in the wild: the data.table package

https://github.com/Rdatatable/data.table/blob/master/_pkgdown.yml

However, the tooltip doesn't appear on their website. https://rdatatable.gitlab.io/data.table/

I couldn't find a way to make it work.

I tried to set it for tmap, r-tmap/tmap@5568c3d

but still shows the default in https://r-tmap.github.io/tmap/dev/

image

@jayhesselberth
Copy link
Collaborator

It looks like the setting in the config file isn't respected, set here:

out$development$version_tooltip <- version_tooltip(pkg$development$mode)

May just need to check for a value before setting?

@hadley hadley added this to the 2.1.0 milestone Jul 4, 2024
@olivroy olivroy linked a pull request Jul 4, 2024 that will close this issue
@hadley hadley removed this from the 2.1.0 milestone Jul 5, 2024
@hadley
Copy link
Member

hadley commented Jul 5, 2024

I don't have time to get this done today, I don't think it's that important, and we're likely to do a patch release in a few weeks, so I'm pushing this to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants