Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is .install_extras ? #2793

Open
kevinrue opened this issue Oct 6, 2024 · 3 comments
Open

What is .install_extras ? #2793

kevinrue opened this issue Oct 6, 2024 · 3 comments

Comments

@kevinrue
Copy link

kevinrue commented Oct 6, 2024

#' listed in `.install_extras`. pkgdown takes a different approach based on

I seem to be running into a situation where this is relevant but I don't understand the mention here.

I have vignettes where the image files are stored in a subdirectory vignettes/screenshots/.

When I reference those image files in my vignette (using either plain markdown or knitr::include_graphics()) the forward slashes get replaced by %2F which in turns ruins the path and prevents those images from displaying properly.

Example:
screenshots%2Fbasic-demo.png

This seems to be a consequence of updating to bootstrap 5 as it used to work until now.

@kevinrue
Copy link
Author

kevinrue commented Oct 7, 2024

If I may rephrase my question / feature request: is it truly impossible to store image files in a subdirectory of vignettes/ ?

It seems a bit picky to "not allow" subdirectories, it feels more organised to separate the actual vignettes from the (potentially many) images they embed.

Many thanks in advance for advice / considering the feature request.

@hadley
Copy link
Member

hadley commented Oct 7, 2024

Can you please provide a simple reprex of the problem that you're seeing?

@kevinrue
Copy link
Author

kevinrue commented Oct 7, 2024

Huh.

On GitHub Pages it works

https://kevinrue.github.io/pkgdown2793/articles/pkgdown2793.html

But this is how it looks on my Apple M1 Max macos 14.6.1 (23G93) in Chrome:

image

With the web inspector telling me the image HTML is:

<img src="images%2Fcat.jpg">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants