Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remotes selects incompatible bioconductor version on R 4.4.0: uses 3.18 instead of 3.19 #798

Open
naikymen opened this issue Jun 3, 2024 · 3 comments

Comments

@naikymen
Copy link

naikymen commented Jun 3, 2024

Hi!

It was apparently decided that bioc 3.19 shouldn't be mapped to R 4.4.0:

# Do not include R 4.4 <-> Bioc 3.19, because R 4.4 will use

However, this can result in bioc version 3.18 being selected, and it is not compatible with R 4.4.0.

This may be because R_BIOC_VERSION is not set in my environment, and because it is not in the version map.

image

It can be observed that this is the case:

image

However, if I copy-paste the source (https://github.com/r-lib/remotes/blob/main/R/bioc-standalone.R) to a script (source.zip) and source it, the correct version pops up:

image

What may be going on?

For context see: Bioconductor/S4Vectors#123

@mtmorgan
Copy link

mtmorgan commented Jun 4, 2024

I think that this is fixed with 041e67b but has not been released to CRAN yet; installing remotes from GitHub would return the correct version of Bioconductor.

@naikymen
Copy link
Author

naikymen commented Jun 4, 2024

Thats great!

Perhaps it would be nice if remotes grabbed the bioc version from BiocManager::version() instead (i.e. if it is installed).

@mtmorgan
Copy link

Note that this can use utils::download.file, but download.file is not in the NAMESPACE. This is also a problem for the 'pkgcache' package, which has a copy-paste version of the same code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants