Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coerce_to_sparse_matrix() doens't handle default values #60

Closed
EmilHvitfeldt opened this issue May 21, 2024 · 2 comments
Closed

coerce_to_sparse_matrix() doens't handle default values #60

EmilHvitfeldt opened this issue May 21, 2024 · 2 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@EmilHvitfeldt
Copy link
Member

look at last 4 columns

sparsevctrs::coerce_to_sparse_matrix(mtcars) |> head()
#> 6 x 11 sparse Matrix of class "dgCMatrix"
#>   [[ suppressing 11 column names 'mpg', 'cyl', 'disp' ... ]]
#>                                                          
#> Mazda RX4         21.0 6 160 110 3.90 2.620 16.46 0 1 4 4
#> Mazda RX4 Wag     21.0 6 160 110 3.90 2.875 17.02 0 1 4 4
#> Datsun 710        22.8 4 108  93 3.85 2.320 18.61 1 1 4 1
#> Hornet 4 Drive    21.4 6 258 110 3.08 3.215 19.44 1 0 3 1
#> Hornet Sportabout 18.7 8 360 175 3.15 3.440 17.02 0 0 3 2
#> Valiant           18.1 6 225 105 2.76 3.460 20.22 1 0 3 1
Matrix::Matrix(as.matrix(mtcars), sparse = TRUE) |> head()
#> 6 x 11 sparse Matrix of class "dgCMatrix"
#>   [[ suppressing 11 column names 'mpg', 'cyl', 'disp' ... ]]
#>                                                          
#> Mazda RX4         21.0 6 160 110 3.90 2.620 16.46 . 1 4 4
#> Mazda RX4 Wag     21.0 6 160 110 3.90 2.875 17.02 . 1 4 4
#> Datsun 710        22.8 4 108  93 3.85 2.320 18.61 1 1 4 1
#> Hornet 4 Drive    21.4 6 258 110 3.08 3.215 19.44 1 . 3 1
#> Hornet Sportabout 18.7 8 360 175 3.15 3.440 17.02 . . 3 2
#> Valiant           18.1 6 225 105 2.76 3.460 20.22 1 . 3 1

Created on 2024-05-21 with reprex v2.1.0

@EmilHvitfeldt EmilHvitfeldt added the bug an unexpected problem or unintended behavior label May 21, 2024
@EmilHvitfeldt
Copy link
Member Author

ideally, these two calls should produce same results

@EmilHvitfeldt
Copy link
Member Author

fixed in #77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant