Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop add pallet fails to correctly resolve relative paths when invoked inside the parachain repo. #67

Closed
weezy20 opened this issue Mar 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@weezy20
Copy link
Contributor

weezy20 commented Mar 18, 2024

Say you create a new parachain : pop new p my-chain
Ignoring the git status for now (maybe fixed by #65 - you can meanwhile cd my-chain, git add ., git commit), if you run pop add pallet from outside my-chain, specifying runtime path as -r my-chain/runtime/src/lib.rs, the cmd works.

However, if you were to cd into my-chain and provide the runtime path as -r runtime/src/lib.rs, the cmd fails:

❯ pop add p template -r runtime/src/lib.rs
T   Pop CLI : Adding pallet "pallet-parachain-template"!
|
Failed to open repository: failed to resolve path '': No such file or directory; class=Os (2); code=NotFound (-3)
Error: Workspace has uncommitted changes, aborting pallet addition
@weezy20 weezy20 added the bug Something isn't working label Mar 18, 2024
weezy20 added a commit that referenced this issue Mar 20, 2024
@weezy20 weezy20 closed this as completed Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant