Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The custom channel seems doesn't work #123

Closed
kangbb opened this issue Sep 26, 2019 · 3 comments
Closed

The custom channel seems doesn't work #123

kangbb opened this issue Sep 26, 2019 · 3 comments

Comments

@kangbb
Copy link

kangbb commented Sep 26, 2019

I hava tried it as following:

(def body (chan 1 (map :body)))
(go (while true
      (println (<! body))))
(go (http/get "https://api.github.com/users"
              {:with-credentials? false
               :query-params      {"since" 135}}
              {:channel body}))

But nothing will print.

@seancorfield
Copy link

seancorfield commented Oct 31, 2019

@kangbb You're passing two maps -- it should just be one:

(go (http/get "https://api.github.com/users"
              {:with-credentials? false
               :query-params      {"since" 135}
               :channel           body}))

@kangbb
Copy link
Author

kangbb commented Oct 31, 2019

@kangbb You're passing two maps -- it should just be one:

(go (http/get "https://api.github.com/users"
              {:with-credentials? false
               :query-params      {"since" 135}
               :channel           body}))

Thanks a lot, it works.

@kangbb kangbb closed this as completed Oct 31, 2019
@kiramclean
Copy link

@kangbb How are you consuming the responses from the custom channel? I'm running into the issue described in #66, but would like to use a custom channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants