Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function redefinition warnings with Clojure/Script 1.11 #135

Open
esp1 opened this issue May 29, 2022 · 1 comment
Open

Function redefinition warnings with Clojure/Script 1.11 #135

esp1 opened this issue May 29, 2022 · 1 comment

Comments

@esp1
Copy link

esp1 commented May 29, 2022

When using Clojure/Script 1.11, you will get function redefinition warnings because cljs-http depends on noencore, which defines parse-long and parse-double functions which are now included in clojure.core.

------ WARNING #1 - :redef -----------------------------------------------------
 Resource: no/en/core.cljc:131:1
--------------------------------------------------------------------------------
 128 |   [s]
 129 |   (parse-number s #(#?(:clj Integer/parseInt :cljs js/parseInt) %1)))
 130 | 
 131 | (defn parse-long
-------^------------------------------------------------------------------------
 parse-long already refers to: cljs.core/parse-long being replaced by: no.en.core/parse-long
--------------------------------------------------------------------------------
 132 |   "Parse `s` as a long number."
 133 |   [s]
 134 |   (parse-number s #(#?(:clj Long/parseLong :cljs js/parseInt) %1)))
 135 | 
--------------------------------------------------------------------------------

------ WARNING #2 - :redef -----------------------------------------------------
 Resource: no/en/core.cljc:136:1
--------------------------------------------------------------------------------
 133 |   [s]
 134 |   (parse-number s #(#?(:clj Long/parseLong :cljs js/parseInt) %1)))
 135 | 
 136 | (defn parse-double
-------^------------------------------------------------------------------------
 parse-double already refers to: cljs.core/parse-double being replaced by: no.en.core/parse-double
--------------------------------------------------------------------------------
 137 |   "Parse `s` as a double number."
 138 |   [s]
 139 |   (parse-number s #(#?(:clj Double/parseDouble :cljs js/parseFloat) %1)))
 140 | 
--------------------------------------------------------------------------------
@ruffnext
Copy link

ruffnext commented Nov 5, 2022

I have fixed this issue. see #137

If the pull request has not been merged for a long time, you can try to use [io.github.ruffnext/cljs-http "0.1.47"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants