Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract TZ picker into package #96

Open
jonthegeek opened this issue Nov 9, 2023 · 0 comments
Open

Abstract TZ picker into package #96

jonthegeek opened this issue Nov 9, 2023 · 0 comments

Comments

@jonthegeek
Copy link
Member

The code for detecting user timezone and allowing them to override that detection is useful. Pull it off into a package and publish.

Strongly consider using tzdb::tzdb_names() rather than OlsonNames() for future-proofing (but requires tzdb/clock for time stuff in that case!). Probably abstract that part out so the places that reference olsonNames() instead call something that knows what this server is using as the source of tz truth.

Make the drop-down optional. Be sure to also allow/support styling.

Ping Eric about it, since it's inspired by his code originally.

Anything else?

This was referenced Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant