Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enum vs String for questType #163

Open
Quazia opened this issue Aug 14, 2023 · 0 comments
Open

Test enum vs String for questType #163

Quazia opened this issue Aug 14, 2023 · 0 comments
Assignees
Labels
improvement changes that improve the security, or performance of the code without modifying the functionality research requires more research; might not actually require implementation

Comments

@Quazia
Copy link
Member

Quazia commented Aug 14, 2023

Even though the questType is hardcoded as a string in the current struct, I still have a suspicion that leveraging an enum appended to the end of the struct would lead to some gas savings. Anywhere we can reduce or remove string types I'm always a proponent of.

For this issue we want to:

  • Create a gas snapshot with the existing implementation (string based questType)
  • Implement enum based questType
  • Evaluate if the savings justifies switching over to enum based gas types
@Quazia Quazia self-assigned this Aug 14, 2023
@Quazia Quazia added improvement changes that improve the security, or performance of the code without modifying the functionality research requires more research; might not actually require implementation labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement changes that improve the security, or performance of the code without modifying the functionality research requires more research; might not actually require implementation
Projects
None yet
Development

No branches or pull requests

1 participant