Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user info if targetsecret changes #242

Open
ArgTang opened this issue Sep 27, 2021 · 10 comments · May be fixed by #896
Open

Update user info if targetsecret changes #242

ArgTang opened this issue Sep 27, 2021 · 10 comments · May be fixed by #896

Comments

@ArgTang
Copy link

ArgTang commented Sep 27, 2021

Is your feature request related to a problem? Please describe.
deploy the user example. then update the password and deploy again. The User is not reconciled with the new password.
This will make it easy for operators to rotate password or fix username typos.

Describe the solution you'd like
When a users original secret is changed it should be reconciled with the new info

  importCredentialsSecret:
    name: rabbit-test-user
@Zerpet
Copy link
Contributor

Zerpet commented Sep 29, 2021

This is an interesting feature request. Although there are two parts to this issue. 1) Updating the password, that's the easy part. 2) Updating the user, this is a bit more tricky because we need a way to determine if the user name has changed, and if so, delete the old one, as you cannot update the username in RabbitMQ. This part is more tricky because it would require that we store state somewhere, likely an annotation.

I'm not sure when we'll get the time to work on this issue, but I'm happy to review and collaborate with you if you submit a PR covering the above scenarios, and any other related scenario you come accross.

@ArgTang
Copy link
Author

ArgTang commented Oct 7, 2021

Right i see the issue for username. annotation or status could "store" the username. I am not fluent in go, but i might take a look

@github-actions
Copy link

github-actions bot commented Dec 7, 2021

This issue has been marked as stale due to 60 days of inactivity. Stale issues will be closed after a further 30 days of inactivity; please remove the stale label in order to prevent this occurring.

@github-actions github-actions bot added the stale label Dec 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Closing stale issue due to further inactivity.

@quain24
Copy link

quain24 commented Apr 20, 2022

Up one - same reasoning as op - inability to rotate passwords using helm upgrade with azure pipelines is very problematic, at least for me.
Workflow is as follows: azure keyvault -> azure pipeline -> helm deployment (upgrade)

@SPFZ
Copy link

SPFZ commented Apr 21, 2022

Similar issue here. We need to be able to rotate the passwords regularly, therefore it would be useful if a change of the password in the secret would also update rabbitmq.

Updating usernames is not a priority for us, as a new user can simply be created.

@SPFZ
Copy link

SPFZ commented Apr 21, 2022

@Zerpet I am happy to help with this if you think it would be useful to add this?! Can you please reopen the issue?

@lerminou
Copy link

lerminou commented Sep 6, 2024

Hi, Do you have any workaround to update a user password ?
/reopen

@Zerpet Zerpet reopened this Sep 13, 2024
@Zerpet
Copy link
Contributor

Zerpet commented Sep 13, 2024

@Zerpet I am happy to help with this if you think it would be useful to add this?! Can you please reopen the issue?

Hi @SPFZ, yes, this enhancement will definitely be useful. If you are still interested/available to drive this forward, I can assign this issue to you?

@SPFZ
Copy link

SPFZ commented Sep 14, 2024

@Zerpet I am happy to help with this if you think it would be useful to add this?! Can you please reopen the issue?

Hi @SPFZ, yes, this enhancement will definitely be useful. If you are still interested/available to drive this forward, I can assign this issue to you?

Hi @Zerpet , I am not working with RabbitMQ at the moment. Therefore I can not contribute anymore.

@Martinif Martinif linked a pull request Oct 31, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants