Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HDF5 backend of fetch_hitemp #295

Closed
erwanp opened this issue Jun 24, 2021 · 0 comments · Fixed by #306
Closed

Change HDF5 backend of fetch_hitemp #295

erwanp opened this issue Jun 24, 2021 · 0 comments · Fixed by #306
Assignees
Labels
todo in the short-term roadmap
Milestone

Comments

@erwanp
Copy link
Member

erwanp commented Jun 24, 2021

🎯 Todo

Fetch_hitemp currently uses Pandas's Pytables to generate HDF5s. We should switch to Vaex :

💡 Implementations

  • fetch_hitemp calls hdf2df. Most changes happen there.
  • we should maintain compatiblity with Pandas's Pytable for the transition. Also with h5py re-add h5py support in cache_files #239 (still not done). I'd refactor hdf2df and introduce a "backend" parameter. Default Vaex.
  • decide if we add a temporary function to convert current .h5 cache files into Vaex's .hdf5 automatically. Could be nice not to have to reload, let's say, the HITEMP-CH4 database.

Tip : you can vote for New Features on https://feathub.com/radis/radis

@erwanp erwanp added the todo in the short-term roadmap label Jun 24, 2021
@erwanp erwanp mentioned this issue Jul 6, 2021
9 tasks
@erwanp erwanp linked a pull request Jul 6, 2021 that will close this issue
9 tasks
@erwanp erwanp self-assigned this Jul 6, 2021
@erwanp erwanp added this to the 0.9.30 milestone Jul 6, 2021
This was referenced Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo in the short-term roadmap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant