-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Miryoku does not work #17
Comments
Try building both sides on separate runs. If I remember correctly, building them together resulted in errors for me. |
Thank you, unfortunately the build still fails with |
I'll try a build later today and report back. |
This didn't build for me today either, it may be worth raising a discussion, as I can't see missing or otherwise missing information on the files. |
Update on this matter! I found the issue and why the build for the temper was broken on Miryoku. I'll keep this documented here for posterity and I'll try posting a PR to Miryoku ZMK. |
Ah yes, I had to move the files to comply with the new Zephyr update but didn't realize it would break the Miryoku build. Thanks for looking into and fixing it! |
The PR regarding the temper has been merged into Miryoku. I tested a build (and flashed) and it now works correctly. Manna also made a sample build which also compiled. @Zoltan-Balazs you can sync your fork and it should now work. This issue could now be marked as closed. |
Thank you, it works as intended, I was able to verify on my own fork as well! |
Whenever I try to build the Miryoku firmware, it does not work, see: https://github.com/Zoltan-Balazs/miryoku_zmk/actions/runs/8844616666
I see that the Temper was added like the Corne to the Miryoku repository; building that in the exact same way, just changing
temper
tocorne
in the shield section is successful: https://github.com/Zoltan-Balazs/miryoku_zmk/actions/runs/8844680219The text was updated successfully, but these errors were encountered: