Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Miryoku does not work #17

Closed
Zoltan-Balazs opened this issue Apr 26, 2024 · 8 comments
Closed

Building Miryoku does not work #17

Zoltan-Balazs opened this issue Apr 26, 2024 · 8 comments

Comments

@Zoltan-Balazs
Copy link

Zoltan-Balazs commented Apr 26, 2024

Whenever I try to build the Miryoku firmware, it does not work, see: https://github.com/Zoltan-Balazs/miryoku_zmk/actions/runs/8844616666

I see that the Temper was added like the Corne to the Miryoku repository; building that in the exact same way, just changing temper to corne in the shield section is successful: https://github.com/Zoltan-Balazs/miryoku_zmk/actions/runs/8844680219

@calerouxz
Copy link

Try building both sides on separate runs. If I remember correctly, building them together resulted in errors for me.

@Zoltan-Balazs
Copy link
Author

Thank you, unfortunately the build still fails with Error: Keymap found but shield not found. Board used for shield.
It seems like the workflow does not recognise temper_right or temper_left as valid shields

@calerouxz
Copy link

I'll try a build later today and report back.

@calerouxz
Copy link

This didn't build for me today either, it may be worth raising a discussion, as I can't see missing or otherwise missing information on the files.

@calerouxz
Copy link

Update on this matter! I found the issue and why the build for the temper was broken on Miryoku. I'll keep this documented here for posterity and I'll try posting a PR to Miryoku ZMK.
The outboard refs for temper needed to be updated, as this commit moved the files on the temper's repository and Miryoku outboards require the refs to build. I've opened this PR to fix it in Miryoku ZMK.

@raeedcho
Copy link
Owner

raeedcho commented May 2, 2024

Ah yes, I had to move the files to comply with the new Zephyr update but didn't realize it would break the Miryoku build. Thanks for looking into and fixing it!

@calerouxz
Copy link

calerouxz commented May 3, 2024

The PR regarding the temper has been merged into Miryoku. I tested a build (and flashed) and it now works correctly. Manna also made a sample build which also compiled. @Zoltan-Balazs you can sync your fork and it should now work.

This issue could now be marked as closed.

@Zoltan-Balazs
Copy link
Author

Thank you, it works as intended, I was able to verify on my own fork as well!
I don't think I would've been able to figure this out, thank you @calerouxz 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants