Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post build hook for running black box tests #42

Open
rafecolton opened this issue May 28, 2014 · 6 comments
Open

post build hook for running black box tests #42

rafecolton opened this issue May 28, 2014 · 6 comments

Comments

@rafecolton
Copy link
Owner

maybe with bats, since it's pretty universal

@colegleason
Copy link
Contributor

@rafecolton Could this post build hook also be used for running arbitrary scripts after a successful job (build/tag/push)?

@rafecolton
Copy link
Owner Author

@colegleason that's the general idea; however, there are some serious security implications of this feature, depending on the implementation. I'm also not 100% sure it's within the scope of this project.

I'd love to hear any thoughts you may have (on either the implementation or the scope).

@colegleason
Copy link
Contributor

Yeah, after thinking about it for a bit I think I will just use docker-builder as a step in a larger CI build. To do that I will need an interface to check on the status of an async build or otherwise block until a build succeeds.

@rafecolton
Copy link
Owner Author

Yeah, running the job synchronously will be a simple thing to add (and already on the TODO list).

Checking the status of the build over HTTP will eventually be added as a feature as well, though that is slightly further down on the list

@rafecolton
Copy link
Owner Author

Maybe a good way to handle this without trying to shove too much functionality into docker-builder is to use outgoing webhooks like Travis/GitHub...

@colegleason
Copy link
Contributor

I think that would be a good feature, but I also like the idea of blocking
until a build completes as it makes it easier to add into scripts and
workflows without adding an HTTP server into the mix to listen for the
webhooks.

On Wed, Jul 2, 2014 at 4:14 PM, Rafe Colton [email protected]
wrote:

Maybe a good way to handle this without trying to shove too much
functionality into docker-builder is to use outgoing webhooks like
Travis/GitHub...


Reply to this email directly or view it on GitHub
#42 (comment)
.

Cole Gleason

Student, University of Illinois at Urbana-Champaign
Email: [email protected]
Website: colegleason.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants