Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing GitHub API token if building with webhook? #90

Open
rafecolton opened this issue Jul 11, 2014 · 3 comments
Open

Providing GitHub API token if building with webhook? #90

rafecolton opened this issue Jul 11, 2014 · 3 comments

Comments

@rafecolton
Copy link
Owner

If no API token is provided to the build server itself, and the request comes through on a webhook as opposed to a request to /docker-build, it wouldn't be possible to clone down a private repo. Do we care? If so, proposed solutions?

@meatballhat
Copy link
Contributor

I care 😺

Why can't we accept an API token in the body of the webhook request? In the case of Travis webhooks, the entire .travis.yml is sent in the payload, so there's an opportunity to read the token from there in the case of private repositories that aren't encrypting the value.

@rafecolton
Copy link
Owner Author

Yeah, that would handle the above case, since it would not be necessary to encrypt the value in a private repo. Are there any standards around where in the .travis.yml to put the value?

@meatballhat
Copy link
Contributor

It's nice to namespace your stuff, but that's about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants