Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default tag #81

Open
cantado opened this issue Oct 25, 2017 · 3 comments
Open

Wrong default tag #81

cantado opened this issue Oct 25, 2017 · 3 comments

Comments

@cantado
Copy link

cantado commented Oct 25, 2017

Hi,

I just realized, that the default tag is wrong if there are more then 10 minor or patch versions in a row. Git sort them alphabetically instead of the version.

For example (version v1.0.0 - v1.12.0):

git tag
# prints:
# v1.0.0
# v1.1.0
# v1.10.0
# v1.11.0
# v1.12.0
# v1.2.0
# v1.3.0
# v1.4.0
# v1.5.0
# v1.6.0
# v1.7.0
# v1.8.0
# v1.9.0
git tag -l --sort=v:refname
# prints:
# v1.0.0
# v1.1.0
# v1.2.0
# v1.3.0
# v1.4.0
# v1.5.0
# v1.6.0
# v1.7.0
# v1.8.0
# v1.9.0
# v1.10.0
# v1.11.0
# v1.12.0

It's just a small change, so i don't create a new pull request.
Please change this line from git tag | tail -n1 to git tag -l --sort=v:refname | tail -n1

Thanks

@rafinskipg
Copy link
Owner

ok! i will add in the new version

@glebcha
Copy link
Collaborator

glebcha commented Jul 17, 2019

@rafinskipg can you add updated tail to master and bump version?

@rafinskipg
Copy link
Owner

Sorry ! Didnt see this, fixing for v2.0.0 #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants