-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with sprockets
#169
Comments
This is the commit that added the dependency: d8bee68, looks like it was made back in July on a PR that was first opened in February: #87 Seems the incompatibility was unexpected, I agree that it would be nice to be able to continue using this tool with |
Would like to add in that upgrading from 0.3.1 to 0.3.2 broke our build because of the introduction of |
Can confirm, build started failing now with 0.3.2 in a project using sprockets. I'll revert to 0.3.1 as well. Relevant part of the log incase it helps:
|
This move to Propshaft has resulted in Sprockets-based test suite failures for me when upgrading from 0.3.1 to 0.3.2: ActionView::Template::Error:
Asset `mission_control/jobs/application.js` was not declared to be precompiled in production.
Declare links to your assets in `app/assets/config/manifest.js`.
//= link mission_control/jobs/application.js
and restart your server
# ./app/views/layouts/application.html.erb:18:in `_app_views_layouts_application_html_erb___4153382308342819861_75060'
# ./spec/requests/authentication_spec.rb:46:in `block (2 levels) in <main>'
# ------------------
# --- Caused by: ---
# Sprockets::Rails::Helper::AssetNotPrecompiledError:
# Asset `mission_control/jobs/application.js` was not declared to be precompiled in production.
# Declare links to your assets in `app/assets/config/manifest.js`.
#
# //= link mission_control/jobs/application.js
#
# and restart your server
# ./app/views/layouts/application.html.erb:18:in `_app_views_layouts_application_html_erb___4153382308342819861_75060'
``` |
My deploy broken using the version 0.3.2. I'm surprised because it should be a bug fix bump version, but we have much more stuff going on.
The new version made me import some assets in the manifest.js:
Would be nice a clean support for Sprocket since I believe the most of people didn't migrated to Propshaft and may be using ESBuild or similar, like me. |
Hey! I just released version 0.3.3, reverting the change that caused this https://github.com/rails/mission_control-jobs/releases/tag/v0.3.3. FWIW, until this is more stable, you can expect breaking changes with little ceremony, but I admit I didn't correctly assess the breakage this one change would cause. Sorry about that! |
Hi! I noticed that PR#87 introduced a dependency on
propshaft
.Was this change intentional, and is it necessary?
It seems that this update has made the gem incompatible with projects that are still using
sprockets
.We’d really love to continue using this gem with
sprockets
if possible. Thank you!The text was updated successfully, but these errors were encountered: