Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Tag Manager with turbolinks: true duplicates pageView when using Push #134

Open
viktorzimmermann opened this issue Jun 7, 2019 · 6 comments
Open

Google Tag Manager with turbolinks: true duplicates pageView when using Push #134

viktorzimmermann opened this issue Jun 7, 2019 · 6 comments
Labels
bug help wanted

Comments

@viktorzimmermann
Copy link

viktorzimmermann commented Jun 7, 2019 •
edited
Loading

It looks like GTM with turbolinks: true (#88) works only for pushing basic page view to the Data Layer:

handler :google_tag_manager, container: 'GTM-123456677', turbolinks: true

which will render in HEAD section:

<script>
      document.addEventListener('turbolinks:load', function(event) {
        var url = event.data.url;
        dataLayer.push({'event':'pageView','virtualUrl': url});
      });
  (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
  new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
  j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
  'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
  })(window,document,'script','dataLayer','GTM-123456677');</script>

Turbolinks will not duplicate this script tag on other page views because it's always exactly the same.

However, when user navigates to another controller (with Turbolinks) where I call something like this:

t.google_tag_manager :push, ecommerce: {
    impressions: @products.map { |product| { id: product.id } }
}

...I end up with two script tags in HEAD section:

<head>
<script>
      document.addEventListener('turbolinks:load', function(event) {
        var url = event.data.url;
        dataLayer.push({'event':'pageView','virtualUrl': url});
      });
  (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
  new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
  j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
  'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
  })(window,document,'script','dataLayer','GTM-123456677');
</script> 
<script>
      document.addEventListener('turbolinks:load', function(event) {
        var url = event.data.url;
          dataLayer.push({"ecommerce":{"currencyCode":"HRK","impressions":[ ........ ]}});
        dataLayer.push({'event':'pageView','virtualUrl': url});
      });
  (function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
  new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
  j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
  'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
  })(window,document,'script','dataLayer','GTM-123456677');
</script>
</head>

This unfortunately creates duplicate pageviews in Analytics etc.

Am I doing something wrong or this is a real issue?
Thanks! :)
@DonSchado
Copy link
Collaborator

@viktorzimmermann sorry that this got lost... do you have an update on this from your side?

@Theminijohn
Copy link

I'm at the exact same point, I can't make it work 🤯 Did you find a solution to this after all @viktorzimmermann ?

@viktorzimmermann
Copy link
Author

Unfortunately I still didn't find any solution. 🙄

@jeanmartin
Copy link

At the same point now myself. Renders rack-tracker useless for me sadly.

@bumi
Copy link
Contributor

bumi commented Nov 25, 2020

sorry, sadly I can not really help here.
Any ideas on how to fix this are welcome.

@DonSchado
Copy link
Collaborator

We released a hotwire/turbo related change, maybe you can check this out: https://github.com/railslove/rack-tracker/pull/160/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bumi @jeanmartin @DonSchado @Theminijohn @viktorzimmermann