Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Bug: extra space in the call leading to BAD_REQUEST: unable to parse query #39

Closed
hrkrshnn opened this issue Sep 9, 2022 · 2 comments · Fixed by #40
Closed

Bug: extra space in the call leading to BAD_REQUEST: unable to parse query #39

hrkrshnn opened this issue Sep 9, 2022 · 2 comments · Fixed by #40

Comments

@hrkrshnn
Copy link
Contributor

hrkrshnn commented Sep 9, 2022

let validator_ids = validator_ids.iter().join(", ");

I think it should be .join(",")

The current implementation produces

Sending: RequestBuilder { method: GET, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("beacon-chain.lighthouse.dappnode")), port: Some(3500), path: "/eth/v1/beacon/states/head/validators", query: Some("id=0x800040778c8f2ef6dc36009975f69a5a3fb6cecbee2fbb0fe5b5a8dc37241fe35e043299cc7c206cc7e522af99cc4a6f%2C+0x8000558843d93fd74ad009d1f120e657c09fea88c44d1d739dccbafdca9e6f5df6d2649825ac7db5f2078aade4bf03cb"), fragment: None }, headers: {} }
-id=0x....99cc4a6f%2C+0x80005
+id=0x....99cc4a6f%2C0x80005
@hrkrshnn
Copy link
Contributor Author

hrkrshnn commented Sep 9, 2022

There are a couple of other places with the same issue. Would be up for submitting a PR.

@ralexstokes
Copy link
Owner

ah nice find!

made an issue to track adding some tests ralexstokes/ethereum-consensus#237

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants